Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split rkyv feature by size_xx. #125

Merged
merged 3 commits into from
Apr 1, 2023
Merged

Conversation

n3vu0r
Copy link
Contributor

@n3vu0r n3vu0r commented Apr 1, 2023

This will support rkyv with different size types.

@mbrubeck
Copy link
Collaborator

mbrubeck commented Apr 1, 2023

Hmm, is there a way we can do this without a breaking change for users of the existing rkyv feature?

@n3vu0r
Copy link
Contributor Author

n3vu0r commented Apr 1, 2023

This should be non-breaking now. I hope I've fixed the workflow. I'm avoiding namespaced-features like dep:rkyv which is not supported by the MSRV of 1.36.0.

@mbrubeck
Copy link
Collaborator

mbrubeck commented Apr 1, 2023

Thanks! By the way, I'm planning to bump the MSRV to 1.60 soon for #119 which also uses namespaced features, so we could use them here too...

@n3vu0r
Copy link
Contributor Author

n3vu0r commented Apr 1, 2023

Great, that makes it a bit nicer.

@mbrubeck mbrubeck merged commit 60c9b15 into reem:master Apr 1, 2023
@mbrubeck
Copy link
Collaborator

This is now published in ordered-float 3.7.0.

@n3vu0r
Copy link
Contributor Author

n3vu0r commented Apr 24, 2023

Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants