Unconditionally bound with T: FloatCore
.
#138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
std
feature was non-additive; that is, it was possible for enabling thestd
feature to break code in another crate. Specifically, consider the following code:This code will compile if the
std
feature is disabled, but then fail when it is enabled becauseOrd for OrderedFloat<T>
requires thatT: Float
, rather thanT: FloatCore
.In order to eliminate this compatibility hazard, instead always require
FloatCore
and, where necessary, also requireFloat
.This is a breaking change; generic code may need updated bounds.
Also, for reasons I do not entirely understand,
#[derive(PartialEq)]
wouldn't compile for theUniformNotNan
andUniformOrdered
distribution types, so I had to replace them with ones with explicit bounds. This may be a sign that something deeper is wrong, or it might be an inadequacy of the rustc trait solver...