Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Debug impls delegate directly to inner float #153

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Make Debug impls delegate directly to inner float #153

merged 1 commit into from
Jul 29, 2024

Conversation

Ten0
Copy link
Contributor

@Ten0 Ten0 commented Jul 29, 2024

Resolves #152

@Ten0 Ten0 force-pushed the direct_debug_impl branch from 0efe673 to 6fae20e Compare July 29, 2024 09:40
mbrubeck
mbrubeck approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbrubeck mbrubeck merged commit 2ef58c4 into reem:master Jul 29, 2024
2 checks passed
@Ten0 Ten0 deleted the direct_debug_impl branch July 29, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrubeck mbrubeck mbrubeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug implementation shouldn't display the NotNan wrapper
2 participants
@Ten0 @mbrubeck