Skip to content

Commit

Permalink
lib: make internal API warning more direct
Browse files Browse the repository at this point in the history
Before:
These APIs are exposed only for testing and are not tracked by any
versioning system or deprecation process.

After:
These APIs are for internal testing only. Do not use them.

PR-URL: nodejs#25125
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and refack committed Jan 10, 2019
1 parent 91cfbdf commit 7d96ef7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions lib/internal/test/binding.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
'use strict';

process.emitWarning(
'These APIs are exposed only for testing and are not ' +
'tracked by any versioning system or deprecation process.',
'These APIs are for internal testing only. Do not use them.',
'internal/test/binding');

module.exports = { internalBinding };
3 changes: 1 addition & 2 deletions lib/internal/test/heap.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
'use strict';

process.emitWarning(
'These APIs are exposed only for testing and are not ' +
'tracked by any versioning system or deprecation process.',
'These APIs are for internal testing only. Do not use them.',
'internal/test/heap');

const { createHeapDump, buildEmbedderGraph } = internalBinding('heap_utils');
Expand Down
3 changes: 1 addition & 2 deletions test/parallel/test-dns-lookup.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ cares.getaddrinfo = () => internalBinding('uv').UV_ENOENT;
common.expectWarning({
// For 'internal/test/binding' module.
'internal/test/binding': [
'These APIs are exposed only for testing and are not ' +
'tracked by any versioning system or deprecation process.'
'These APIs are for internal testing only. Do not use them.'
],
// For dns.promises.
'ExperimentalWarning': [
Expand Down
3 changes: 1 addition & 2 deletions test/parallel/test-fs-filehandle.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ let fdnum;

common.expectWarning({
'internal/test/binding': [
'These APIs are exposed only for testing ' +
'and are not tracked by any versioning system or deprecation process.',
'These APIs are for internal testing only. Do not use them.',
common.noWarnCode
],
'Warning': [
Expand Down

0 comments on commit 7d96ef7

Please sign in to comment.