Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] replace preferred-pm with package-manager-detector #6242

Closed
benmccann opened this issue Aug 8, 2024 · 3 comments · Fixed by #6250 or #6253
Closed

[FEAT] replace preferred-pm with package-manager-detector #6242

benmccann opened this issue Aug 8, 2024 · 3 comments · Fixed by #6250 or #6253
Labels
enhancement New feature or request

Comments

@benmccann
Copy link
Contributor

Is your feature request related to a problem? Please describe.

preferred-pm pulls in 24 dependencies, which is unnecessary for what it does: https://npmgraph.js.org/?q=preferred-pm

package-manager-detector has no dependencies: https://npmgraph.js.org/?q=package-manager-detector

Describe alternatives you've considered

No response

Additional context

This code has been battle-tested for a long time in the heavily used @antfu/ni. It was recently extracted out into its own library. I am switching Svelte's CLI to use it: svelte-add/svelte-add#535

Describe the thing to improve

Reduce the number of dependencies

@benmccann benmccann added the enhancement New feature or request label Aug 8, 2024
@BatuhanW
Copy link
Member

Hey @benmccann looks like a good idea, would you like to work on this?

@aliemir
Copy link
Member

aliemir commented Aug 21, 2024

Thanks to @benmccann, this issue is addressed in #6250 for @refinedev/devtools-server. preferred-pm is also used in @refinedev/cli and same changes can be applied to it as well. If anyone is interested on working on this, please let us know 🙏 We'll be happy to see new contributors 🚀

@BatuhanW BatuhanW linked a pull request Sep 2, 2024 that will close this issue
emrecancorapci pushed a commit to emrecancorapci/refine that referenced this issue Sep 4, 2024
emrecancorapci pushed a commit to emrecancorapci/refine that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants
@benmccann @aliemir @BatuhanW and others