applying phantom ipv4 address from the reg response #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewust
requested changes
Jul 11, 2024
| @@ -429,14 +434,25 @@ func (rm *RegistrationManager) NewRegistrationC2SWrapper(c2sw *pb.C2SWrapper, in | |||
| c2s.TransportParams = rr.GetTransportParams() | |||
| } | |||
|
|
|||
| // TODO: future, apply the ip addresses from the Registration response (rr.IPv4Addr, rr.IPv6Addr) | |||
| // apply the ip addresses from the registration response, if the Ipv4Addr is not empty | |||
| if rr.Ipv4Addr != nil && *rr.Ipv4Addr != 0 { | |||
There was a problem hiding this comment.
We should also allow override for IPv6, not just v4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having the station derive the phantom IPv4 for a given bidirectional registration that the station is informed about, let the station apply the IPv4 it receives from the reg server (inside the reg response).
This allows clients to dial phantoms that are not necessarily in the ClientConf subnets, given that they registered using the bidirectional api.