Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loong64 support #106

Merged
merged 3 commits into from
Oct 17, 2022
Merged

add loong64 support #106

merged 3 commits into from
Oct 17, 2022

Conversation

cheungxi
Copy link
Contributor

loong64 (loongarch64) a new isa

@yetist
Copy link

yetist commented Oct 16, 2022

@gaukas

Please review this patch, otherwise I have to use it like this:

    go mod edit -replace=github.com/refraction-networking/utls=github.com/cheungxi/utls@master
    go mod tidy                                                                  

Thanks.

@gaukas
Copy link
Contributor

gaukas commented Oct 16, 2022

Hi @yetist,

I don't really have any major blocker to get this merged. But since loong64 is not even included in go/internal, I'd like to know how are you using other packages on this ISA and what is the specific usage of using uTLS on it.

I guess that's a very personal question, feel free not to respond ;)

And since this PR doesn't really introduce any new function or urgent fix, it might not make a new PR but rather get combined into the next release. Thanks.

And thanks to @cheungxi for contributing!

@gaukas
Copy link
Contributor

gaukas commented Oct 16, 2022

And also I don't really have a good way to test on different ISAs, that's a reason I was not merging either this PR or #102. Before I go ahead and merge it, have you checked that this would work instead of breaking anything? Just to make sure.

@gaukas gaukas merged commit 862fe37 into refraction-networking:master Oct 17, 2022
@VeNoMouS
Copy link
Contributor

Just to clarify... this is to support the cpu arch related to golang/go#46229 ?

@gaukas
Copy link
Contributor

gaukas commented Oct 31, 2022

Yes, I believe they are referring to the same architecture by loong64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants