Fix disableCssAnimation bug when using multiple viewports #610
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadackel
force-pushed
the
fix/viewport-bugs
branch
from
1091863
to
2bdab36
Compare
Quramy
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The bug occurs when using a viewport with
hasTouchorisMobile, or when a page reload is performed using thereloadAfterChangeViewportflag. ThedisableCssAnimationis not enabled for shots taken after a page reload.I've modified the logic to add an element to disable CSS Animation again on page reload.
How to reproduce
See wadackel/storycap-reproduce-viewport-bug.
Actual Behavior
Default_iPadDefault_iPhone11Expected Behavior (patched)
Default_iPadDefault_iPhone11Notes
In the process of debugging, it was necessary to run
yarn linkfor each package included in monorepo.I've added an npm script to make this easier.