Add the ability to screenshot a part of the screen #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good. Would you write about this option to README.md ? |
Jamie5
force-pushed
the
partialScreenshot
branch
from
2a544d5
to
c8b7678
Compare
|
@Quramy added some docs to README.md |
|
Thanks! |
throwandgo
added a commit
to remix/storycap
that referenced
this pull request
Oct 4, 2023
Pull in new changes from reg-viz/storycap, including the ability to shard screenshot captures across machines. We anticipate using this feature to ease the burden placed on individual CircleCI instances, since screenshot captures can be resource- and time-intensive. Resolved conflicts on: - packages/storycap/package.json - packages/storycap/src/node/capturing-browser.ts - packages/storycap/src/shared/screenshot-options-helper.ts Since we last synced from upstream, the following changes have been accepted: - Add the ability to screenshot a part of the screen (reg-viz#722) - Fixed exposeFunction not being awaited (reg-viz#632) We continue to maintain this fork because we're waiting for this issue to be addressed: - Expose setViewport on window reg-viz#624 This sync is reflected in a version bump of our fork from 1.0.4 to 1.1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, especially in situations with
playfunctions, we may need to adjust some of the UI but only be interested in taking a screenshot of a portion of the UI. This allows us to specify what portion of the screen we want the screenshot taken.To some extent resolves #506 (this does not allow passing a selector string, but it is easy to convert a selector string to a bounding box, and using a bounding box provides us more flexibility).