Add a workaround for an issue where puppeteer fails to find a matching element #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed that the e2e test for this example fails due to an issue described at reg-viz#712
|
@Quramy |
Quramy
approved these changes
Jun 14, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #712.
This PR adds a workaround for an issue where puppeteer throws an error when finding an element specified by
clickorfocusoptions if storycap is used with React 18.I was not able to dig into a root cause for the issue but found that running an empty function within a page prevents the issue with no side effects.
Though we are using an old version of puppeteer-core due to #545, the issue is still reproduced even if puppeteer-core gets updated to its latest.