Limit to only using require to let Rollup bundler to detect the file as cjs file #857
Conversation
indigolain
force-pushed
the
limit-to-only-using-require
branch
from
87d873d
to
2aab9be
Compare
indigolain
force-pushed
the
limit-to-only-using-require
branch
from
f4424e4
to
2aab9be
Compare
| @@ -80,6 +80,7 @@ export class StoriesBrowser extends BaseBrowser { | |||
| timeout: 60_000, | |||
| }, | |||
| ); | |||
| await this.page.waitForTimeout(500); | |||
There was a problem hiding this comment.
It seems to throw an Execution context was destroyed error if we don't wait for some time here, so I added some timeouts. I'm not sure why this is happening though.
ref: https://github.com/reg-viz/storycap/actions/runs/8354226734/job/22867216673#step:7:99
|
when will this pr be merged? waiting for this 👍 |
This comment was marked as resolved.
This comment was marked as resolved.
|
@Quramy Without setting this resolve.alias, when you try to build the storybook, it will result in throwing the following error. => Failed to build the preview
Error: [commonjs--resolver] Failed to resolve entry for package "storycap". The package may have incorrect main/module/exports specified in its package.json.It seems that the I've added a pre hooks to build-storybook for populating the storycap build with 5c26134 to resolve the error you are getting, should this resolve the issue? |
examples/v8-vite5/package.json
Outdated
| "build-storybook": "storybook build", | ||
| "prestorybook": "../../scripts/e2e-prestorybook.js .", | ||
| "prebuild-storybook": "../../scripts/e2e-prestorybook.js .", | ||
| "storycap:all": "yarn prestorybook && yarn test && storycap --verbose --server-timeout 100000 --server-cmd \"storybook dev -p 9009\" \"http://localhost:9009\"" |
There was a problem hiding this comment.
It should be tested with not dev mode but production build such as:
"storycap:all": "yarn build-storybook && yarn test && storycap --verbose --server-timeout 100000 --server-cmd \"http-server -p 9009 storybook-static\" \"http://127.0.0.1:9009\""Note
The following script requires yarn add http-server -D
| import { ScreenshotOptions } from '../shared/types'; | ||
| import { triggerScreenshot } from './trigger-screenshot'; | ||
| import type { ScreenshotOptions } from '../shared/types'; | ||
| const { triggerScreenshot } = require('./trigger-screenshot'); |
There was a problem hiding this comment.
Is it means that import statements are prohibited under storycap/src/client ? 🤔
|
Thank you!! |
May fix #856 ?
Having import statements in a file makes
@rollup/plugin-commonjsto skip the conversion from CommonJS to ES Module.Changing the import statement to require should make
@rollup/plugin-commonjshandle the file and successfully convert it.