Skip to content

Commit

Permalink
view: update wlr_toplevel size on client resizes
Browse files Browse the repository at this point in the history
If a floating client resizes itself, sway updates several of its
internal dimensions to match but not wlr_toplevel. This means that the
next time wlroots sends a toplevel configure event, it can have wrong
coordinates that resize the client back to its old size. To fix this,
let's just use wlr_xdg_toplevel_set_size so the wlr_toplevel has the
same dimensions as sway. Fixes swaywm#5266.
  • Loading branch information
Dudemanguy committed Aug 26, 2023
1 parent 4a22105 commit 0183b9d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions sway/tree/view.c
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,11 @@ void view_update_size(struct sway_view *view) {
con->pending.content_width = view->geometry.width;
con->pending.content_height = view->geometry.height;
container_set_geometry_from_content(con);

// Update the next scheduled width/height so correct coordinates
// are sent on the next toplevel configure from wlroots.
wlr_xdg_toplevel_set_size(view->wlr_xdg_toplevel, view->geometry.width,
view->geometry.height);
}

void view_center_surface(struct sway_view *view) {
Expand Down

0 comments on commit 0183b9d

Please sign in to comment.