Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sway-regolith packaging/1.8-regolith does not install onto Debian testing #12

Closed
kgilmer opened this issue Feb 3, 2024 · 10 comments
Closed
Labels
bug Something isn't working

Comments

@kgilmer
Copy link
Member

kgilmer commented Feb 3, 2024

Installation error: https://github.com/regolith-linux/voulage/actions/runs/7751147390/job/21138574163

Changing the wlroots dependency in meson.build results in this compile-time error:

FAILED: sway/sway-regolith.p/ipc-json.c.o 
cc -Isway/sway-regolith.p -Isway -I../sway -Iinclude -I../include -Iprotocols -I/usr/include/cairo -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/json-c -I/usr/include/libevdev-1.0/ -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/gio-unix-2.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -DWLR_USE_UNSTABLE -Wno-unused-parameter -Wno-unused-result -Wno-missing-braces -Wundef -Wvla '-DSYSCONFDIR="//etc"' '-DSWAY_VERSION="1.8"' -fmacro-prefix-map=../= -g -O2 -ffile-prefix-map=/home/kgilmer/adhoc/sway-regolith=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wno-error=deprecated-declarations -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -MD -MQ sway/sway-regolith.p/ipc-json.c.o -MF sway/sway-regolith.p/ipc-json.c.o.d -o sway/sway-regolith.p/ipc-json.c.o -c ../sway/ipc-json.c
In file included from ../sway/ipc-json.c:21:
../include/sway/desktop/idle_inhibit_v1.h:4:10: fatal error: wlr/types/wlr_idle.h: No such file or directory
    4 | #include <wlr/types/wlr_idle.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
@kgilmer kgilmer added the bug Something isn't working label Feb 3, 2024
@SoumyaRanjanPatnaik
Copy link
Collaborator

Is this fixed? I'll try investigating...

@SoumyaRanjanPatnaik
Copy link
Collaborator

Does packaging/1.7-regolith work?

@kgilmer
Copy link
Member Author

kgilmer commented Feb 4, 2024

No, I think this is a case of Debian being ahead of Ubuntu. the wlroots dependency expressed by meson cannot be found, and when I update the dependency to the version in Debian, the error above is what I get.

Here is the build error when building 1.7 branch on debian testing:

$ debuild -sa -b
...
Dependency wlroots found: NO found 0.17.1 but need: '<0.16.0' ; matched: '>=0.15.0'
Dependency lookup for wlroots with method 'pkgconfig' failed: Invalid version, need 'wlroots' ['<0.16.0'] found '0.17.1'.
CMake binary for 1 is cached.
...

@SoumyaRanjanPatnaik
Copy link
Collaborator

Ohhh... But 1.9 has yet to be released. Should I go ahead and package that anyway?

@SoumyaRanjanPatnaik
Copy link
Collaborator

Its currently at rc2: https://github.com/swaywm/sway/releases

@kgilmer
Copy link
Member Author

kgilmer commented Feb 6, 2024

Ah that's fine, I don't think it makes sense to create a package for something until it's been released. I disabled sway-regolith for now in the integration test. Once things are ready we can renable. This same situation currently holds for regolith-control-center as well, as GNOME46 landed there recently I believe.

@kgilmer
Copy link
Member Author

kgilmer commented Feb 18, 2024

Seeing same issue when attempting to build sway-regolith for Ubuntu Noble

FAILED: sway/sway-regolith.p/ipc-json.c.o 
cc -Isway/sway-regolith.p -Isway -I../sway -Iinclude -I../include -Iprotocols -I/usr/include/cairo -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/json-c -I/usr/include/libevdev-1.0/ -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/gio-unix-2.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -DWLR_USE_UNSTABLE -Wno-unused-parameter -Wno-unused-result -Wno-missing-braces -Wundef -Wvla '-DSYSCONFDIR="//etc"' '-DSWAY_VERSION="1.8"' -fmacro-prefix-map=../= -g -O2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/home/kgilmer/ad-hoc/sway-regolith=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/home/kgilmer/ad-hoc/sway-regolith=/usr/src/sway-regolith-1.8.1-4 -Wno-error=deprecated-declarations -Wdate-time -D_FORTIFY_SOURCE=3 -pthread -MD -MQ sway/sway-regolith.p/ipc-json.c.o -MF sway/sway-regolith.p/ipc-json.c.o.d -o sway/sway-regolith.p/ipc-json.c.o -c ../sway/ipc-json.c
In file included from ../sway/ipc-json.c:21:
../include/sway/desktop/idle_inhibit_v1.h:4:10: fatal error: wlr/types/wlr_idle.h: No such file or directory
    4 | #include <wlr/types/wlr_idle.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Disabling the package build for now.

kgilmer pushed a commit that referenced this issue Mar 11, 2024
In case a display is unplugged, the sway output may be removed from the
userdata before the gamma_control can be reset. In this case we can't
schedule a commit on the output, simply return within the function.

backtrace full:

  #0  handle_gamma_control_set_gamma (listener=0x4856a8 <server+616>, data=0x7ffce1ed59c0) at ../sway/desktop/output.c:1105
          server = 0x485440 <server>
          event = 0x7ffce1ed59c0
          output = 0x0
  #1  0x00007f430d1dca0c in wl_signal_emit_mutable ()
     from /nix/store/ky1g6ylzr2m4bq8fy0gzrnqmjr6948k5-wayland-1.22.0/lib/libwayland-server.so.0
  No symbol table info available.
  #2  0x00007f430d142370 in gamma_control_destroy (gamma_control=0x29eb9b0) at ../types/wlr_gamma_control_v1.c:37
          manager = 0x27e33e0
          output = 0x2a10770
          event = {output = 0x2a10770, control = 0x0}
  #3  0x00007f430d14239b in gamma_control_handle_output_destroy (listener=<optimized out>, data=<optimized out>)
      at ../types/wlr_gamma_control_v1.c:59
          gamma_control = <optimized out>
  #4  0x00007f430d1dca0c in wl_signal_emit_mutable ()
     from /nix/store/ky1g6ylzr2m4bq8fy0gzrnqmjr6948k5-wayland-1.22.0/lib/libwayland-server.so.0
  No symbol table info available.
  #5  0x00007f430d12a0e0 in wlr_output_destroy (output=output@entry=0x2a10770) at ../types/output/output.c:384
          cursor = <optimized out>
          tmp_cursor = <optimized out>
          layer = <optimized out>
          tmp_layer = <optimized out>
  #6  0x00007f430d114ecf in disconnect_drm_connector (conn=conn@entry=0x2a10770) at ../backend/drm/drm.c:1757
          __PRETTY_FUNCTION__ = "disconnect_drm_connector"
  #7  0x00007f430d117078 in scan_drm_connectors (drm=drm@entry=0x1eebab0, event=event@entry=0x7ffce1ed5c1c) at ../backend/drm/drm.c:1597
          c = <optimized out>
          wlr_conn = 0x2a10770
          drm_conn = 0x2e760d0
          conn_id = <optimized out>
          index = 4
          i = 4
          res = 0x2e761f0
          seen_len = 5
          seen = {true, true, true, true, true, false}
          new_outputs_len = 0
          new_outputs = 0x7ffce1ed5ab0
          conn = <optimized out>
          tmp_conn = <optimized out>
          index = <optimized out>
  #8  0x00007f430d113425 in handle_dev_change (listener=0x1eebbb0, data=0x7ffce1ed5c18) at ../backend/drm/backend.c:157
          drm = 0x1eebab0
          change = 0x7ffce1ed5c18
  #9  0x00007f430d1dca0c in wl_signal_emit_mutable ()
     from /nix/store/ky1g6ylzr2m4bq8fy0gzrnqmjr6948k5-wayland-1.22.0/lib/libwayland-server.so.0
  No symbol table info available.
  #10 0x00007f430d111696 in handle_udev_event (fd=<optimized out>, mask=<optimized out>, data=<optimized out>)
      at ../backend/session/session.c:213
          event = {type = WLR_DEVICE_HOTPLUG, {hotplug = {connector_id = 0, prop_id = 0}}}
          devnum = <optimized out>
          dev = 0x1ed9460
          session = <optimized out>
          udev_dev = 0x2e70db0
          sysname = 0x2e73c60 "card0"
          devnode = <optimized out>
          action = 0x7f430d6677b5 "change"
          seat = <optimized out>
          __PRETTY_FUNCTION__ = "handle_udev_event"
  #11 0x00007f430d1de8e2 in wl_event_loop_dispatch ()
     from /nix/store/ky1g6ylzr2m4bq8fy0gzrnqmjr6948k5-wayland-1.22.0/lib/libwayland-server.so.0
  No symbol table info available.
  #12 0x00007f430d1dc445 in wl_display_run () from /nix/store/ky1g6ylzr2m4bq8fy0gzrnqmjr6948k5-wayland-1.22.0/lib/libwayland-server.so.0
  No symbol table info available.
  #13 0x000000000041daa5 in server_run (server=server@entry=0x485440 <server>) at ../sway/server.c:338
  No locals.
  #14 0x000000000041cf4d in main (argc=<optimized out>, argv=0x7ffce1ed5fe8) at ../sway/main.c:415
          verbose = false
          debug = false
          validate = false
          allow_unsupported_gpu = false
          config_path = 0x0
        c = <optimized out>

where event->output->data is NULL:

  (gdb) p event->output->data
  $5 = (void *) 0x0
@kgilmer
Copy link
Member Author

kgilmer commented Mar 11, 2024

Merged upstream 1.9 release into master and pushed to packaging/v1.9-regolith for testing

@kgilmer
Copy link
Member Author

kgilmer commented Mar 11, 2024

@kgilmer
Copy link
Member Author

kgilmer commented Apr 19, 2024

closing since we moved to sway 1.9

@kgilmer kgilmer closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants