Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost piggyback follow-up #1847

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Boost piggyback follow-up #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dde8e79
add test for arrow feedstock
h-vetinari Sep 29, 2023
2715d83
fix dependency detection for boost-cpp with pins
h-vetinari Sep 29, 2023
d55ff7c
fix case of None appearing in requirements
h-vetinari Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions conda_forge_tick/migrators/libboost.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ def _process_section(name, attrs, lines):
host_req = reqs.get("host", set()) or set()
run_req = reqs.get("run", set()) or set()

is_boost_in_build = "boost-cpp" in build_req
is_boost_in_host = "boost-cpp" in host_req
is_boost_in_run = "boost-cpp" in run_req
is_boost_in_build = any((x or "").startswith("boost-cpp") for x in build_req)
is_boost_in_host = any((x or "").startswith("boost-cpp") for x in host_req)
is_boost_in_run = any((x or "").startswith("boost-cpp") for x in run_req)

# anything behind a comment needs to get replaced first, so it
# doesn't mess up the counts below
Expand Down
2 changes: 2 additions & 0 deletions tests/test_libboost.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
("gudhi", "1.10.0"),
# single output; with run-dep
("carve", "1.10.0"),
# multiple output; no run-dep
("arrow", "1.10.0"),
# multiple outputs, many don't depend on boost; comment trickiness
("fenics", "1.10.0"),
# multiple outputs, jinja-style pinning
Expand Down
Loading
Loading