Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize m_clientmeta in MConfig constructor and change it to BOOL #8

Merged
merged 2 commits into from
Jun 28, 2017

Conversation

In-line
Copy link
Contributor

@In-line In-line commented Jun 28, 2017

No description provided.

@In-line In-line changed the title Initialize m_clientmeta in MConfig constructor Initialize m_clientmeta in MConfig constructor and change it to bool Jun 28, 2017
@@ -36,7 +36,7 @@ class MConfig
int m_debuglevel; // to use for meta_debug
char* m_gamedll; // string if specified in config.ini
char* m_exec_cfg; // ie exec.cfg
int m_clientmeta;
bool m_clientmeta;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bad idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theAsmodai sizeof(BOOL) == 4 so should be fine, thanks to @s1lentq

@In-line In-line changed the title Initialize m_clientmeta in MConfig constructor and change it to bool Initialize m_clientmeta in MConfig constructor and change it to BOOL Jun 28, 2017
change "false" to "no"
@s1lentq s1lentq merged commit ff18513 into rehlds:master Jun 28, 2017
@In-line In-line deleted the patch-1 branch June 28, 2017 18:33
@stamepicmorg stamepicmorg added Type: 🚀 enhancement Improvement or addition of a new feature. Status: ✅ done The issue done and closed. Priority: ⚠️ medium Medium priority tasks that should be addressed soon. OS: 💻 Independent Case do not refer to any OS. labels Mar 12, 2018
@jeefo jeefo mentioned this pull request Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: 💻 Independent Case do not refer to any OS. Priority: ⚠️ medium Medium priority tasks that should be addressed soon. Status: ✅ done The issue done and closed. Type: 🚀 enhancement Improvement or addition of a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants