Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes and code refactor #942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GermanAizek
Copy link

@s1lentq hello, review PR changes and feedback me.

@fred0r
Copy link

fred0r commented Mar 11, 2023

been using this pr for some weeks now on linux with regamedll_cs and the hitboxes 'feel' much more 'accurate/natural' than before.
the downside is that the hltv often gets disconnected with Dropped from x.x.x.x:27015 (Reliable channel overflowed).
in my setup the server records every map played.

@justgo97
Copy link

been using this pr for some weeks now on linux with regamedll_cs and the hitboxes 'feel' much more 'accurate/natural' than before. the downside is that the hltv often gets disconnected with Dropped from x.x.x.x:27015 (Reliable channel overflowed). in my setup the server records every map played.

The PR doesn't include any changes to how hitboxes function.

@GermanAizek
Copy link
Author

@fred0r @justgo97 I had already forgotten about this PR, it turns out that someone else answered me. HLTV breakdown is possible due to delete operator or additional checks, I can divide this PR into two parts, where refactoring and where fixes.

@GermanAizek
Copy link
Author

@justgo97 rehlds project is still active, are you doing it? In September, I created a PR, but no one answered it.

@justgo97
Copy link

@justgo97 rehlds project is still active, are you doing it? In September, I created a PR, but no one answered it.

I'm not the project manager, I'm a normal user like you, I guess you can try to divide the PR to address one issue at a time, It will be easier to review and test the changes, no guarantee you will get an answer from the maintainers though.

@s1lentq s1lentq force-pushed the master branch 2 times, most recently from 43df0ba to de3679f Compare September 20, 2023 14:00
@GermanAizek
Copy link
Author

@s1lentq I accidentally made a force push.
I hope you have pick up necessary fixes?
Added new commit with fix minor memleak 1fa34c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants