Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement -pingboost 4 for behavior similar to mm_insane 1 in Linux #976

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

cris840
Copy link

@cris840 cris840 commented Jul 1, 2023

Implemented the Sleep_Pingboost4 function to achieve similar behavior to mm_insane 1 of the mmtimer metamod, since the function does not perform any further action, sleep is removed.

Implemented the Sleep_Pingboost4 function to achieve similar behavior to mm_insane 1 of the mmtimer metamod, since the function does not perform any further action, sleep is removed.
Copy link
Author

@cris840 cris840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

@axl303
Copy link

axl303 commented Jul 11, 2023

Sorry for my stupid comment/question,
What would be the benefits/is there any from -pingboost4 and should we use it over -pingboost3?

@cris840
Copy link
Author

cris840 commented Jul 11, 2023

Sorry for my stupid comment/question, What would be the benefits/is there any from -pingboost4 and should we use it over -pingboost3?

It's simple, in short:

-pingboost 3 is designed to control Sleep on network operations with precision while the network subsystem does its internal tasks.

-pingboost 4 does not perform any Sleep and simply returns the function without doing anything. This means that the CPU will be fully utilized without waiting or suspending execution. This can be used in order to increase FPS to "insane" levels ;)
Like mmtimer Metamod

@cris840 cris840 closed this Jul 11, 2023
@cris840 cris840 reopened this Jul 11, 2023
@SmilexGamer
Copy link

Implemented the Sleep_Pingboost4 function to achieve similar behavior to mm_insane 1 of the mmtimer metamod, since the function does not perform any further action, sleep is removed.

Couldn't this be implemented also in Windows?

@cris840
Copy link
Author

cris840 commented Jul 11, 2023

Implemented the Sleep_Pingboost4 function to achieve similar behavior to mm_insane 1 of the mmtimer metamod, since the function does not perform any further action, sleep is removed.

Couldn't this be implemented also in Windows?

On Windows you can use the mmtimer metamod directly and use mm_insane 1 in server.cfg to have the same result.

@SmilexGamer
Copy link

Implemented the Sleep_Pingboost4 function to achieve similar behavior to mm_insane 1 of the mmtimer metamod, since the function does not perform any further action, sleep is removed.

Couldn't this be implemented also in Windows?

On Windows you can use the mmtimer metamod directly and use mm_insane 1 in server.cfg to have the same result.

Doesn't that apply also to Linux? You can use the mmtimer too. If we're implementing this in reHLDS, it should be in both platforms.

@cris840
Copy link
Author

cris840 commented Jul 12, 2023

Implementé la función Sleep_Pingboost4 para lograr un comportamiento similar a mm_insane 1 del metamod mmtimer, ya que la función no realiza ninguna otra acción, se elimina el sueño.

¿No se podría implementar esto también en Windows?

En Windows, puede usar el metamod mmtimer directamente y usar mm_insane 1 en server.cfg para obtener el mismo resultado.

¿Eso no se aplica también a Linux? También puede utilizar el mmtimer. Si estamos implementando esto en reHLDS, debería estar en ambas plataformas.

Implemented the Sleep_Pingboost4 function to achieve similar behavior to mm_insane 1 of the mmtimer metamod, since the function does not perform any further action, sleep is removed.

Couldn't this be implemented also in Windows?

On Windows you can use the mmtimer metamod directly and use mm_insane 1 in server.cfg to have the same result.

Doesn't that apply also to Linux? You can use the mmtimer too. If we're implementing this in reHLDS, it should be in both platforms.

pingboost does not exist in the Windows version of ReHLDS
Look: https://github.com/dreamstalker/rehlds/blob/master/rehlds/dedicated/src/sys_window.cpp

And no, unfortunately there is no working version of mmtimer for Linux. It would need to be updated, but there is no point in doing so when it can be implemented directly in ReHLDS.

@stambeto2006
Copy link

@cris840 It would be a good idea and useful if it was built to work on Windows as well without adding unnecessary extras that are not guaranteed to work 100%.

@cris840 cris840 requested a review from justgo97 July 13, 2023 21:04
@cris840 cris840 marked this pull request as draft July 13, 2023 21:04
@hun1er
Copy link

hun1er commented Aug 12, 2023

@stambeto2006 , @SmilexGamer You can use this which is compatible with HLDS and ReHLDS and works on both Windows and Linux. It has a similar feature (pingboost 5) and even more.

@s1lentq s1lentq force-pushed the master branch 2 times, most recently from 43df0ba to de3679f Compare September 20, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants