Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

Upgrade gitlibs. This also address the issue with private keys #58

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sanel
Copy link

@sanel sanel commented Apr 11, 2023

tools.gitlibs now uses git directly, instead of Jsch, so workarounds are no longer necessary. Password protected private keys are now handled just like they are done through normal git command.

Addressing #57

tools.gitlibs now uses `git` directly, instead of Jsch, so workarounds
are no longer necessary. Password protected private keys are now
handled just like they are done through normal `git` command.

Addressing reifyhealth#57
@sanel
Copy link
Author

sanel commented Apr 11, 2023

I haven't updated README.md and I just tested it against a private github repository, which works without problems.

@reifyrobot
Copy link

This PR is being flagged as STALE because it has not had recent activity in the last 60 days. It will be closed if no further activity occurs in the next 14 days. If you believe this repo should be excluded from this process, please add the repo to this list.

@rome-user
Copy link

@manderson202 Are there objections to the changes in this PR?

@manderson202
Copy link
Collaborator

Hi, thanks for the PR and the feedback here... sorry we haven't been able to get back on this. I did pull down the code and the integration tests failed for me, but I didn't get a chance to troubleshoot why. If you can get the tests passing I can take another look.

@reifyrobot
Copy link

This PR is being flagged as STALE because it has not had recent activity in the last 60 days. It will be closed if no further activity occurs in the next 14 days. If you believe this repo should be excluded from this process, please add the repo to this list.

@Sandarr95
Copy link

Hi, I've taken a quick look at why the tests fail. It seems to be because the test-project references the version that's set in the PR ("0.4.2"), but that can't be found. Running locally with this PR linked in the checkouts, the tests ran fine. Can I do anything to help move this along?

@rome-user
Copy link

Is the version bump in the project.clj needed for the tests to run against this PR? If not, then I think it would be best to remove that version bump, and let the maintainers of this project do it themselves when it's time to cut a new release of the plugin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants