Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactoring for alpha version #12

Merged
merged 12 commits into from
Jul 20, 2023
Merged

chore: refactoring for alpha version #12

merged 12 commits into from
Jul 20, 2023

Conversation

Eagle941
Copy link
Contributor

@Eagle941 Eagle941 commented Jul 17, 2023 •
edited
Loading

  • Changed module name to github.com/reilabs/gnark-extractor to use it as library
  • Added Lean prelude in exported circuit
  • Moved semaphore test to demo repo
  • Replaced print with log
  • ExportCircuit now returns string instead of printing circuit for easier embedding

@Eagle941 Eagle941 requested a review from kustosz July 17, 2023 21:02
kustosz
kustosz approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please apply the feedback before merging.

extractor/lean_export.go Show resolved Hide resolved
extractor/lean_export.go Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
extractor/lean_export.go Outdated Show resolved Hide resolved
extractor/lean_export.go Show resolved Hide resolved
extractor/lean_export.go Outdated Show resolved Hide resolved
@Eagle941 Eagle941 mentioned this pull request Jul 19, 2023
Closed
@Eagle941 Eagle941 merged commit 27502f8 into main Jul 20, 2023
@Eagle941 Eagle941 deleted the prod_changes branch July 20, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kustosz kustosz kustosz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eagle941 @kustosz