Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Removing definegadget #18

Merged
merged 15 commits into from
Jul 21, 2023
Merged

feat: Removing definegadget #18

merged 15 commits into from
Jul 21, 2023

Conversation

Eagle941
Copy link
Contributor

@Eagle941 Eagle941 commented Jul 21, 2023 •
edited
Loading

Refactoring of the gadget API. Backwards compatible, but not actively supported.

Before:

slice_2 := api.DefineGadget(&SliceGadget{
    In_1: make([]frontend.Variable, 2),
    In_2: make([]frontend.Variable, 2),
})
slice_2.Call(SliceGadget{circuit.Tree, circuit.Tree})

After:

api.Call(SliceGadget{circuit.Tree, circuit.Tree})

@Eagle941 Eagle941 linked an issue Jul 21, 2023 that may be closed by this pull request
Removing DefineGadget #15
Closed
@Eagle941 Eagle941 requested a review from kustosz July 21, 2023 08:36
kustosz
kustosz approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@Eagle941 Eagle941 merged commit a439b70 into main Jul 21, 2023
@Eagle941 Eagle941 deleted the removing-definegadget branch July 21, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kustosz kustosz kustosz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing DefineGadget
2 participants
@Eagle941 @kustosz