-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: void
return gadgets, multiple circuits export and Vector
optimisation
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eagle941
changed the title
feat:
feat: Sep 9, 2023
void
return gadgetsvoid
return gadgets and multiple gadgets export
Eagle941
force-pushed
the
flatten_slice_fix
branch
from
September 12, 2023 17:19
f50771d
to
70d62dd
Compare
Eagle941
changed the title
feat:
feat: Sep 18, 2023
void
return gadgets and multiple gadgets exportvoid
return gadgets, multiple circuits export and Vector
optimisation
kustosz
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
void
.frontend.Compiler
interface forCodeExtractor
and implemented functionsField()
andFieldBitLen()
.Vectors
extraction: the extractor checks if it's possible to pass the whole vector instead of reconstructing it.frontend.Variable
slicesPlus other stability hotfixes.
Details
Stability hotfixes:
flattenSlice
)F
type forConst
fields, except forint
types (achieved by creation of a new typeInteger
)abstractor.CallGadget
to make sure the argument is of typefrontend.API
nil
input variables initialised to 0cloneGadget
which wouldn't deep copy nested slices. I have imported the librarymitchellh/copystructure
as a better alternative to homebrewed solution.Additional test examples included plus automatic check of test output with reference extracted circuit.
Checklist