Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved Gadget API #9

Merged
merged 10 commits into from
Jul 5, 2023
Merged

feat: improved Gadget API #9

merged 10 commits into from
Jul 5, 2023

Conversation

Eagle941
Copy link
Contributor

@Eagle941 Eagle941 commented Jul 1, 2023 •
edited
Loading

Issue #5 Improvement to the useability of the Gadget API.

@Eagle941 Eagle941 changed the title Gadget API feat: improved Gadget API Jul 4, 2023
@Eagle941 Eagle941 requested a review from kustosz July 4, 2023 22:18
kustosz
kustosz approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one naming nitpick! Looking forward to seeing this in action with Semaphore!

abstractor/abstractor.go Outdated Show resolved Hide resolved
@Eagle941 Eagle941 merged commit 70db057 into main Jul 5, 2023
@Eagle941 Eagle941 deleted the gadget branch July 5, 2023 16:10
@Eagle941 Eagle941 mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kustosz kustosz kustosz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eagle941 @kustosz