Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ert--print-backtrace has been removed in latest Emacs #49

Closed
qhuyduong opened this issue Nov 2, 2018 · 4 comments
Closed

ert--print-backtrace has been removed in latest Emacs #49

qhuyduong opened this issue Nov 2, 2018 · 4 comments
Assignees

Comments

@qhuyduong
Copy link

qhuyduong commented Nov 2, 2018

ert--print-backtrace has been removed with this commit

emacs-mirror/emacs@e09120d

So ert-runner can't work with latest Emacs. Please help to fix.

Thanks

@phst
Copy link
Collaborator

phst commented Jan 27, 2019

It looks like this should now use backtrace-to-string.

@Fuco1 Fuco1 self-assigned this Jan 28, 2019
@anquegi
Copy link

anquegi commented Aug 6, 2019

Until, it will we updated we can use a workaround in test-helper.el, for emacs major-version bigger than 26:

(when (> emacs-major-version 26)
(defalias 'ert--print-backtrace 'backtrace-to-string))

bad tests:

learn/emacs/neural-networks-and-chaos took 2s
➜ cask exec ert-runner

Test addition-test backtrace:


Test addition-test condition:

    (ert-test-failed
     ((should
       (=
	(+ 2 1)
	4))
      :form
      (= 3 4)
      :value nil))

F

Ran 1 test in 0.084 seconds
1 unexpected results:
   FAILED  addition-test

Corrected tests:

➜ cask exec ert-runner

.

Ran 1 test in 0.000 seconds

@cireu
Copy link

cireu commented Sep 25, 2019

How about now? It's not an important issue but really annoying and confusing.

@seagle0128
Copy link

Any update?

sergeyklay added a commit to zephir-lang/zephir-mode that referenced this issue Mar 16, 2020
Failed tests can't print backtrace on Emacs > 26 because
`ert--print-backtrace' has been removed in latest Emacs versions.

For more see:

- emacs-mirror/emacs@e09120d
- rejeep/ert-runner.el#49
sergeyklay added a commit to sergeyklay/bnf-mode that referenced this issue Mar 16, 2020
Failed tests can't print backtrace on Emacs > 26 because
`ert--print-backtrace' has been removed in latest Emacs versions.

For more see:

- emacs-mirror/emacs@e09120d
- rejeep/ert-runner.el#49
@Fuco1 Fuco1 closed this as completed in ac0d77a Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants