feat: Add scope to CertificateStore with issuerPrivateAddress #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnarea
requested changes
Mar 9, 2022
| @Throws(KeyStoreBackendException::class) | ||
| suspend fun save(certificate: Certificate, chain: List<Certificate> = emptyList()) { | ||
| suspend fun save( | ||
| scope: Scope, |
There was a problem hiding this comment.
In all these methods, I think the scope shouldn't be the first param because it's secondary. For example:
save(cert, scope, ...).retrieveLatest(privateAddress, scope, ...)- And so on
| @@ -8,43 +8,55 @@ import tech.relaycorp.relaynet.wrappers.x509.Certificate | |||
|
|
|||
| abstract class CertificateStore { | |||
|
|
|||
| enum class Scope(val value: String) { | |||
There was a problem hiding this comment.
For consistency with the rest of the library, can you please make this a top level definition named CertificateScope?
|
|
||
| assertEquals(certificate, certificationPath.leafCertificate) | ||
| assertEquals(certificateChain, certificationPath.chain) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Existing certification path of another scope should not be returned`() = runBlockingTest { |
There was a problem hiding this comment.
Please add a test like this for each of the other methods altered in this PR.
sdsantos
changed the title
|
🎉 This PR is included in version 1.63.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for relaycorp/relaynet-gateway-android#571