Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore support for Android 5-7 #133

Merged
merged 4 commits into from
Aug 19, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ android {

defaultConfig {
applicationId "tech.relaycorp.ping"
minSdkVersion 26
minSdkVersion 21
targetSdkVersion 30
versionCode 7
versionName project.findProperty("versionName") ?: "0.7"
Expand Down Expand Up @@ -68,8 +68,7 @@ android {
}
}
compileOptions {
// Workaround for https://github.com/relaycorp/awala-ping-android/issues/39
// coreLibraryDesugaringEnabled true
coreLibraryDesugaringEnabled true

sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
Expand Down
23 changes: 11 additions & 12 deletions app/firebase-test-lab.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,17 @@ spec:
test: app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk
timeout: 30m
device:
# TODO: Test on Android API < 26 once we restore support for it.
# # Asus Nexus 7 (physical). The oldest device we're testing.
# - model: flo
# version: 21 # Android 5.0
# locale: en
# orientation: portrait
#
# # Nexus 5X (virtual)
# - model: Nexus5X
# version: 24 # Android 7.0
# locale: en
# orientation: portrait
# Asus Nexus 7 (physical). The oldest device we're testing.
- model: flo
version: 21 # Android 5.0
locale: en
orientation: portrait

# Nexus 5X (virtual)
- model: Nexus5X
version: 24 # Android 7.0
locale: en
orientation: portrait

# Nexus 5X (virtual)
- model: Nexus5X
Expand Down
3 changes: 0 additions & 3 deletions app/lint.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,4 @@
<issue id="SelectableText" severity="ignore" />
<issue id="UnusedIds" severity="informational" />
<issue id="UnusedResources" severity="informational" />

<!-- TODO: Remove once we restore support for Android API < 26 -->
<issue id="ObsoleteSdkInt" severity="informational" />
</lint>
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ buildscript {
}
}
dependencies {
classpath 'com.android.tools.build:gradle:4.2.2'
classpath 'com.android.tools.build:gradle:7.0.0'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
classpath "com.mikepenz.aboutlibraries.plugin:aboutlibraries-plugin:$aboutLibrariesVersion"
}
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists