Occasional IOException when invalid parcel is delivered to server

[sdsantos]

Stacktrace:

     Caused by: java.io.IOException: unexpected end of stream on http://127.0.0.1:13276/...
        at okhttp3.internal.http1.Http1ExchangeCodec.readResponseHeaders(Http1ExchangeCodec.kt:202)
        at okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:106)
        at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:79)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100)
        at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100)
        at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:82)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100)
        at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100)
        at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100)
        at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:197)
        at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:502)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
        at java.lang.Thread.run(Thread.java:764)
     Caused by: java.io.EOFException: \n not found: limit=0 content=…
        at okio.RealBufferedSource.readUtf8LineStrict(RealBufferedSource.kt:348)
        at okhttp3.internal.http1.HeadersReader.readLine(HeadersReader.kt:29)
        at okhttp3.internal.http1.Http1ExchangeCodec.readResponseHeaders(Http1ExchangeCodec.kt:178)
        at okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:106) 
        at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:79) 
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100) 
        at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34) 
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100) 
        at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:82) 
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100) 
        at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83) 
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100) 
        at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76) 
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:100) 
        at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:197) 
        at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:502) 
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162) 
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636) 
        at java.lang.Thread.run(Thread.java:764) 

[gnarea]

Thanks @sdsantos! Do you have any instrumentation test that I can run to reproduce this?

[gnarea]

I just saw #148. I guess this is the one: https://github.com/relaycorp/relaynet-gateway-android/pull/148/files#diff-df42236b43325bce033d57f8711d3af6R70-R79

[sdsantos]

I just saw relaycorp/relaynet-gateway-android#148. I guess this is the one: https://github.com/relaycorp/relaynet-gateway-android/pull/148/files#diff-df42236b43325bce033d57f8711d3af6R70-R79

Exactly.

[gnarea]

I can't run the test because the branch is broken due to a few compile errors: https://github.com/relaycorp/relaynet-gateway-android/pull/148/checks?check_run_id=1181531058 -- I'll get back to it when they've been fixed.

[gnarea]

This issue has actually uncovered two separate issues:

• The endpoint is returning a malformed HTTP response when the parcel is refused. It seems like the response headers weren't actually sent to the client! Yet all the unit tests passed -- it's great we're writing functional tests 😄
  • I fixed that in 1ab4b95
  • I also changed the PoWeb lib to output more helpful errors: fix: Treat malformed HTTP responses as connection errors awala-poweb-jvm#63
• Unfortunately, parcelDelivery_invalidParcel is still failing. But now I think this is an issue with the test suite (failed to connect to /127.0.0.1 (port 13276) from /127.0.0.1 (port 46116) after 10000ms: isConnected failed: ECONNREFUSED (Connection refused)). Can you please look into it @sdsantos?

[gnarea]

Actually, this issue is technically fixed now and the remaining issue seems to be introduced in #148, so I'm closing this issue now so we can pick up the convo in the PR.