Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Parcel Sync instrumented tests #148

Merged
merged 12 commits into from
Oct 1, 2020

Conversation

sdsantos
Copy link
Collaborator

No description provided.

@gnarea
Copy link
Member

gnarea commented Sep 30, 2020

@sdsantos, following up on #149 (comment), I think parcelDelivery_invalidParcel is now failing because the server isn't available when we make the request:

java.lang.Exception: Unexpected exception, expected<tech.relaycorp.poweb.RejectedParcelException> but was<tech.relaycorp.poweb.ServerConnectionException>
(...)
Caused by tech.relaycorp.poweb.ServerConnectionException: Failed to connect to http://127.0.0.1:13276/v1/parcels
(...)
Caused by: java.net.ConnectException: Failed to connect to /127.0.0.1:13276
(...)
Caused by: java.net.ConnectException: failed to connect to /127.0.0.1 (port 13276) from /127.0.0.1 (port 43068) after 10000ms: (...)
Caused by: android.system.ErrnoException: isConnected failed: ECONNREFUSED (Connection refused)

@gnarea
Copy link
Member

gnarea commented Sep 30, 2020

Wait what!? My last two commits seem to have fixed the instrumentation test suite. But I'd just tested them in a separate branch where I implemented them as a POC and the test failed with the error above: parcel-delivery-instrumented-test...IOException-bugfix-poc

I suspect this is still an intermittent issue, but maybe my commits made them less frequent: relaycorp/awala-poweb-jvm#63 makes the client retry if it can't connect to the server the first time round.

I'm re-running the CI to see what happens next.

@gnarea
Copy link
Member

gnarea commented Sep 30, 2020

Yeah, my latest changes have unintentionally made the issue less frequent, but the test is still flaky: https://console.firebase.google.com/u/0/project/relaynet-gateway-android/testlab/histories/bh.fce322cdd2254629/matrices/6458808712135122226 (that's for the last CI run)

I think the test should wait until the server is ready to receive connections.

…orp/relaynet-gateway-android into parcel-delivery-instrumented-test
…orp/relaynet-gateway-android into parcel-delivery-instrumented-test
@sdsantos sdsantos force-pushed the parcel-delivery-instrumented-test branch from 3ca6261 to 90baecf Compare September 30, 2020 15:14
@sdsantos sdsantos changed the title chore: Parcel Delivery instrumented test chore: Parcel Sync instrumented tests Sep 30, 2020
@sdsantos sdsantos force-pushed the parcel-delivery-instrumented-test branch from 427b603 to 1817178 Compare September 30, 2020 18:11
@sdsantos sdsantos added the automerge Allow kodiak to automerge commit when all checks pass label Oct 1, 2020
@kodiakhq kodiakhq bot merged commit 54bc905 into master Oct 1, 2020
@kodiakhq kodiakhq bot deleted the parcel-delivery-instrumented-test branch October 1, 2020 08:56
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allow kodiak to automerge commit when all checks pass released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants