Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository.directory field to package.jsons #269

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Add repository.directory field to package.jsons #269

merged 1 commit into from
Aug 16, 2021

Conversation

ybiquitous
Copy link
Contributor

@ybiquitous ybiquitous commented Aug 16, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This change updates the repository field in all the package.json files by the following Bash script.
https://gist.github.com/ybiquitous/48f69d29194ed1aecf9b85097da51715

For example:

$ /tmp/update-repository.sh https://github.com/remarkjs/remark-lint

Also, this modifies the scripts to get the repository URLs.

Close #268

This change updates the `repository` field in all the `package.json` files by the following Bash script.
https://gist.github.com/ybiquitous/48f69d29194ed1aecf9b85097da51715

For example:

```console
$ /tmp/update-repository.sh https://github.com/remarkjs/remark-lint
```

Also, this modifies the scripts to get the repository URLs.

Close #268
@ybiquitous ybiquitous marked this pull request as ready for review August 16, 2021 06:19
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Aug 16, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 16, 2021
@codecov-commenter

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented Aug 16, 2021

Hi Masafumi! That’s a great idea. I didn’t know about directory, that seems like perhaps a newish feature.
I believe the npm website used to link the packages correctly, that it did allow folders in the repository. Perhaps due to this directory that that changed?

@wooorm wooorm changed the title Add repository.directory field to package.json Add repository.directory field to package.jsons Aug 16, 2021
@wooorm wooorm merged commit 359cd08 into remarkjs:main Aug 16, 2021
@github-actions

This comment has been minimized.

@wooorm wooorm added 🏗 area/tools This affects tooling 🏡 area/internal This affects the hidden internals 💪 phase/solved Post is done 🦋 type/enhancement This is great to have labels Aug 16, 2021
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 16, 2021
@ybiquitous ybiquitous deleted the issue-268 branch August 16, 2021 09:33
@ybiquitous
Copy link
Contributor Author

ybiquitous commented Aug 16, 2021

@wooorm Yes, the directory field was added by the following RFC:

https://github.com/npm/rfcs/blob/06c656f74ea58f0a2672c7a0c084ba696e2220f8/implemented/0010-monorepo-subdirectory-declaration.md

Perhaps due to this directory that that changed?

Sorry, I don't know about it. 😓

Perhaps, it seems that this repository field is not considered on the npmjs.com website now.
For example, @babel/core has the repository field in the package.json, but the directory (packages/babel-core) is not linked on the npmjs.com/package/@babel/core page.

@wooorm
Copy link
Member

wooorm commented Aug 17, 2021

Released!

@ybiquitous
Copy link
Contributor Author

@wooorm Thank you! 🎉

simnalamburt pushed a commit to simnalamburt/remark-lint that referenced this pull request Mar 19, 2024
This change updates the `repository` field in all `package.json`s to add a `directory`.
This also modifies the scripts to get the repository URLs.

Closes remarkjsGH-268.
Closes remarkjsGH-269.

Reviewed-by: Titus Wormer <tituswormer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏡 area/internal This affects the hidden internals 🏗 area/tools This affects tooling 💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

Add repository.directory field to package.json
3 participants