Dont require trailing : to enforce semantic headings

[benbalter]

This pull request removes the requirement that emphasis-based headings must have trailing punctuation in order to be flagged as invalid to more aggressively enforce semantic headings. I can't think of when this would cause a false positive, if on a line by itself.

It seems strange to me, that the rule's documentation states that # test: would be valid, even though that would conflict with no-heading-punctuation.

[benbalter]

One thing to note, I just ran npm run build-rules. Not sure why the docs got so mangled. Halp?

[wooorm]

Thanks! Don’t worry about the build, it’s not very contributor friendly. You can run npm test, that does all the building and stuff!

[wooorm]

It’s a while ago since I worked on it; I think I added the : because they were in this example from the source of initial rules.

Personally, I use strong emphasis currently in my API sections, e.g., this section from hastscript

### `h(selector?[, properties][, children])`

DSL for creating virtual [HAST][] trees.

**Parameters**:

*   `selector` (`string`, optional)
    — Simple CSS selector, e.g., tag names (`foo`), IDs (`#bar`)
    and classes (`.baz`) are supported,
    defaults to a `div` element.

...

**Returns**: [`Node`][hast-node] — A HAST node.

(maybe it’s not very “semantic” but it looks good)

...but I see now that your proposed change allows my usage because I use two nodes.

Meaning, I like this! Thanks!

[benbalter]

You can run npm test, that does all the building and stuff!

Had some trouble getting things to run locally (my fault, now resolved). Man, those tests are brutal (in the best way possible). Now passing. 😄

Personally, I use strong emphasis currently in my API sections, e.g., this section from hastscript

I think that's fine, and added an explicit test via 952780b to ensure that remains valid (since the next node is a list item, not a paragraph).

[wooorm]

Green! Looks good, @benbalter!

Thanks for taking the time to do a PR, and by the way, thanks for choosing remark-lint, hope you have a pleasent flight 😉

Yes! The tests are quite heavy. Great to see you figured it out though, hope they helped!

I’ll merge this later today, but don’t wait in #360 for it being released, I’d like to combine it with some more stuff if something comes up this week!