Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for image, imageReference #29

Closed
rjhilgefort opened this issue Jan 6, 2019 · 6 comments · Fixed by #30
Closed

Add support for image, imageReference #29

rjhilgefort opened this issue Jan 6, 2019 · 6 comments · Fixed by #30
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have

Comments

@rjhilgefort
Copy link

Doesn't look like it tries to validate images that are specified to be auto-expanded and rendered with the ![](image.jpg) syntax. Given that foo.jpg doesn't exist:

This doesn't show a warning:

![](image.jpg)

And this does:

[](image.jpg)
@wooorm
Copy link
Member

wooorm commented Jan 7, 2019

Hmm, correct, only link and linkReference are supported.

Could you expand on why you expected this to be supported?

@rjhilgefort
Copy link
Author

I guess I just assumed that if [](image.jpg) was checked than ![][image.jpg] would be checked too. My apologies.

@wooorm wooorm reopened this Jan 8, 2019
@wooorm
Copy link
Member

wooorm commented Jan 8, 2019

Don’t worry, was just wondering what your reasoning was. I think it makes sense to add it!

@wooorm wooorm changed the title Doesn't validate auto-expand references: ![](foo.jpg) Add support for image, imageReference Jan 8, 2019
wooorm added a commit that referenced this issue Jan 8, 2019
@wooorm
Add support for checking images, image references
080dc2f 
Closes GH-29.
@wooorm wooorm added 🧑 semver/major This is a change has pr labels Jan 8, 2019
@wooorm wooorm mentioned this issue Jan 8, 2019
Merged
@rjhilgefort
Copy link
Author

❤️ Thanks for adding it!

@wooorm
Copy link
Member

wooorm commented Jan 8, 2019

Sure, thanks for raising the issue 👍

I’m waiting ’till #26 is resolved (which has an external dependency), and would also like to see what happens in #28, before I merge it though.

If I forget and it’s important to you feel free to ping again in a week or so and I’ll move things along anyway!

@rjhilgefort
Copy link
Author

Sounds good!

@wooorm wooorm closed this as completed in #30 Jan 9, 2019
wooorm added a commit that referenced this issue Jan 9, 2019
@wooorm
Add support for checking images, image references
6920834 
Closes GH-29.
Closes GH-30.

Reviewed-by: Rob Hilgefort <rob.hilgefort.me>
Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have labels Aug 15, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for checking images, image references remarkjs/remark-validate-links
2 participants
@wooorm @rjhilgefort