Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitLab, BitBucket #17

Closed
wants to merge 1 commit into from

Conversation

alexander-akait
Copy link

@alexander-akait alexander-akait commented Aug 17, 2017

@wooorm friendly ping
Fix #16

@wooorm
Copy link
Member

wooorm commented Aug 17, 2017

👋

  1. Why are you running remark-validate-links, if the repo is not supported?
  2. Shouldn’t we try to add support for gitlab repos?
  3. Would it make sense to throw an error on unsupported repos?

@alexander-akait
Copy link
Author

alexander-akait commented Aug 17, 2017

  1. I have one remark preset for all repos, also which outside from github, yep i can disable plugin (now it is workaround), but we can just return and avoid this problem. I have a common repo with configuration (linters, presets, editorconfig and etc) and I'm synchronizing it with all the repositories (include github and gitlab and other) and I would not want to have different configurations for different types where stored repositories.
  2. It is be great, but need implement gitlab package, we can do it in future 👍
  3. Maybe, but it is also fix other problem (look https://github.com/zeke/github-url-to-object/blob/master/index.js#L42 https://github.com/zeke/github-url-to-object/blob/master/index.js#L50), we can have broken url in package.json.

@wooorm
Copy link
Member

wooorm commented Aug 20, 2017

  1. It is be great, but need implement gitlab package, we can do it in future 👍

Really? Is it that hard? For GH support, there’s no github package used either?

  1. Maybe, but it is also fix other problem (look https://github.com/zeke/github-url-to-object/blob/master/index.js#L42 https://github.com/zeke/github-url-to-object/blob/master/index.js#L50), we can have broken url in package.json.

We should probably throw a nice error on those, not just exit cleanly?

@alexander-akait
Copy link
Author

@wooorm
2. I don't known maybe it is not hard, just don't have time for this now 😞
3. Ok, let's throw error 👍

@wooorm
Copy link
Member

wooorm commented Aug 21, 2017

No, it’s not hard. There’s only a few lines of code involved. There’s no network connection needed for remark-validate-links, just the file-system is accessed.

Could you provide me a list of valid repository settings in package.json for GitLab projects? gitlab:<gitlabname>/<gitlabrepo>, what else?

@alexander-akait
Copy link
Author

@wooorm seems only gitlab:<gitlabname>/<gitlabrepo>

@wooorm wooorm closed this in c88aed4 Aug 22, 2017
@wooorm
Copy link
Member

wooorm commented Aug 22, 2017

I added proper support for GitLab (which was easy) and Bitbucket (which was hard), which should be published in a few minutes!

@alexander-akait alexander-akait deleted the fix-16 branch August 23, 2017 09:11
@alexander-akait
Copy link
Author

@wooorm thanks!

@wooorm wooorm changed the title fix: don't fail when repo url is not github Support GitLab, BitBucket Aug 15, 2019
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Aug 15, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

Problems with gitlab repository field
2 participants