Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark-figure-caption to list of plugins #1221

Closed
wants to merge 2 commits into from
Closed

Add remark-figure-caption to list of plugins #1221

wants to merge 2 commits into from

Conversation

naiyerasif
Copy link

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This change adds remark-figure-caption which transforms image with alt text to figure with caption element.

Signed-off-by: Naiyer Asif <19614213+naiyerasif@users.noreply.github.com>
Signed-off-by: Naiyer Asif <19614213+naiyerasif@users.noreply.github.com>
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 26, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (7cc0432) 100.00% compared to head (0ca5702) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1221   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          874       874           
=========================================
  Hits           874       874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @naiyerasif! 👋
Thanks for sharing!

I'm a little cautious, because this appears to focus on HTML output, but is a remark (markdown) plugin. (More context on the unified ecosystem https://unifiedjs.com/learn/guide/introduction-to-unified/)
This would likely be a better fit as a HTML/hast/rehype plugin.

There was some work towards this already in https://github.com/josestg/rehype-figure, but I'm not sure if it has all the features you need.

@naiyerasif
Copy link
Author

Hi @ChristianMurphy, I wanted to keep the scope of this plugin confined to MDAST by doing minimal transformations to generate an accessible figure element. But I do see your point. I might have to fork https://github.com/josestg/rehype-figure since it is not covering all my test cases.

Closing this PR for now.

@naiyerasif naiyerasif closed this Aug 26, 2023
@github-actions
Copy link

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤞 phase/open Post is being triaged manually
Development

Successfully merging this pull request may close these issues.

3 participants