-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remark-videos
to list of plugins
#1289
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Chai <7232280+Chailotl@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 142 142
=========================================
Hits 142 142 ☔ View full report in Codecov by Sentry. |
Thanks! Some suggestions:
|
I saw some remark plugins that generate HTML, such as
The
That's a fair suggestion, I'll look into adding it. |
Welcome @Chailotl!
The
Those add new syntax features to markdown, they need to integrate with the parser. |
Oh- right, my plugin only checks for the .mp4 extension 😅 I wrote the plugin well past midnight so forgive my memory |
No worries! Some other ideas:
Adding on to this. ![alternate text](http://example.com/url "title text") There could be an opportunity to offer some combination of:
|
Initial checklist
Description of changes
I added a link to the remark-videos plugin that I developed.