types: use typings provided by remark #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
added
☂️ area/types
ChristianMurphy
commented
Sep 1, 2020
| @@ -158,7 +158,7 @@ async function runRemark(document: vscode.TextDocument, range: vscode.Range): Pr | |||
| if (result.messages.length !== 0) { | |||
| let message = ''; | |||
|
|
|||
| result.messages.forEach((value: string) => { | |||
| result.messages.forEach((value) => { | |||
There was a problem hiding this comment.
in this case, value is a VFileMessage
asbjornu
reviewed
Sep 1, 2020
This corrects the typing, which is tested by Additional unit tests are wonderful, but would likely be out of scope of a typing fix. (?) |
Ok, fair enough. |
|
Thanks, @ChristianMurphy! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with remark version 11, remark has provided typings as part of the package.