-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tsc
on changed examples
#92
Comments
@mcansh It seems that |
This issue has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from issues that are unactionable. Please reach out if you have more information for us! 🙂 |
This issue has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this issue will be automatically closed. |
We're working on this, stay tuned! |
As reported by @mcansh in #83 (comment), we had some TypeScript errors when fixing the
useActionData
/useLoaderData
usage.It would be great if we could run
tsc
in CI, so we don't have to manually check for these kind of errors.As I pointed out in #83 (comment), this would require running
npm install
& sometimes even more (likenpx prisma migrate dev
), otherwise TypeScript would complain. 😢This could be solved by having a
setup
script, but that still would require us to runnpm install && npm run -s setup
on all example folders (see #83 (comment)).@mcansh Pointed out this could be prevented by only running the changed example and not the others (see #83 (comment)), which would probably require some
git
magic, but isn't unnecessary complicated I think.The text was updated successfully, but these errors were encountered: