fix(_official-blog-tutorial): fix useActionData/useLoaderData usage

[MichaelDeBoey]

See https://github.com/remix-run/remix/releases/tag/remix@1.6.5

---

Closes #34

[kentcdodds]

Same comment as the other tutorial. Thanks!

[mcansh]

unfortunately this causes a bunch of typescript errors due to only returning the error for the specific input resulting in

Property 'email' does not exist on type 'SerializeObject<UndefinedToOptional<{ email: string; }>> | SerializeObject<UndefinedToOptional<{ password: string; }>>'.

this should be fixable in remix itself by concatenating all the keys into a single SerializeObject<UndefinedToOptional<{ password?: string; email?: string }>> type, but i'm not sure if others have feelings about not doing that

edit: we should probably run tsc on PRs like we do eslint

[MichaelDeBoey]

unfortunately this causes a bunch of typescript errors due to only returning the error for the specific input

@mcansh Fixed these errors

we should probably run tsc on PRs like we do eslint

Although that would be a good idea to not have these issues, it will require an npm install (& sometimes even more, like npx prisma migrate dev), otherwise TypeScript will complain 😢

[mcansh]

it will require an npm install (& sometimes even more, like npx prisma migrate dev), otherwise TypeScript will complain 😢

oof yeah that's true 😞

[mcansh]

unrelated to changes here, but looks like React now wants startTransition to return void or undefined

app/entry.client.tsx:7:5 - error TS2322: Type 'Root' is not assignable to type 'VoidOrUndefinedOnly'.

  7     hydrateRoot(
        ~~~~~~~~~~~~
  8       document,
    ~~~~~~~~~~~~~~~
... 
 11       </StrictMode>
    ~~~~~~~~~~~~~~~~~~~
 12     )
    ~~~~~

  node_modules/@types/react/index.d.ts:1107:38
    1107     export type TransitionFunction = () => VoidOrUndefinedOnly;
                                              ~~~~~~~~~~~~~~~~~~~~~~~~~
    The expected type comes from the return type of this signature.


Found 1 error.

error Command failed with exit code 1.

-  startTransition(() =>
+  startTransition(() => {
    hydrateRoot(
      document,
      <StrictMode>
        <RemixBrowser />
      </StrictMode>
    )
-  );
+  });

[MichaelDeBoey]

unrelated to changes here, but looks like React now wants startTransition to return void or undefined

I'll create a separate PR for it 👍

[mcansh]

I'll create a separate PR for it 👍

😬 #91 - you can take on the templates if you'd like 😉

[MichaelDeBoey]

oof yeah that's true 😞

Would love to find a solution for this though 🤔

Maybe a setup script for all extra stuff that needs to happen in order to make TS happy? 🤔

It would still take a long time to run npm install && npm run -s setup on all the example folders though 🤔😕

[mcansh]

unless we can tell which example changed and only run tsc on that

[MichaelDeBoey]

@mcansh Created an issue to discuss it further: #92