Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable v2_routeConvention flag #334

Merged

Conversation

MichaelDeBoey
Copy link
Member

Revival of @mcansh's #201

Got the same problem on the pathless-routes example though:

⚠️ Route Path Collision: "/articles"

The following routes all define the same URL, only the first one will be used

🟢 routes/articles._layout.tsx
⭕️️ routes/articles.tsx

@brophdawg11
Copy link

I think that was an old bug we fixed - I updated that example to 1.19.3 and it worked ok.

I'm realizing most of our examples don't have v2 flags enabled 😬 . Not a v2 blocker but we'll want to get that handled after we release. At the moment we could probably update them all to 1.19.3?

@mcansh
Copy link
Contributor

mcansh commented Aug 31, 2023

I'm realizing most of our examples don't have v2 flags enabled 😬 . Not a v2 blocker but we'll want to get that handled after we release. At the moment we could probably update them all to 1.19.3?

yep, that was the desired result of #172 so it didnt block any v2 and each example would be incrementally updated to future flags and subsequently v2

@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Aug 31, 2023

I'm realizing most of our examples don't have v2 flags enabled

@brophdawg11 This is the first step towards enabling all of them, but didn't want to do 1 big PR for all v2 flags (other PRs are incoming as well)

@MichaelDeBoey MichaelDeBoey force-pushed the enable-v2_routeConvention-flag branch 3 times, most recently from bf858f4 to 4fde61f Compare September 1, 2023 14:45
@MichaelDeBoey MichaelDeBoey force-pushed the enable-v2_routeConvention-flag branch from 4fde61f to c30d7f2 Compare September 1, 2023 14:45
@brophdawg11
Copy link

@MichaelDeBoey yeah I agree one by one is the way to go. Should we update them all to 1.19.3 in this PR (or a separate one) to resolve the pathless layout route issue above? I don't have a preference if we do it here or separately - this LGTM

@MichaelDeBoey
Copy link
Member Author

@brophdawg11 I'll do it in a separate PR after merging this one

@MichaelDeBoey MichaelDeBoey merged commit ee33582 into remix-run:main Sep 5, 2023
@MichaelDeBoey MichaelDeBoey deleted the enable-v2_routeConvention-flag branch September 5, 2023 17:27
@MichaelDeBoey
Copy link
Member Author

@brophdawg11 Done in #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants