-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add @biomejs/biome
#143
base: main
Are you sure you want to change the base?
add @biomejs/biome
#143
Conversation
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Expect the GitHub Action step for Biome to fail in this one as we don't have any files that are scanned. This will be corrected in future, as the formatter and linter are enabled in the future. |
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Hey @kinggoesgaming, I appreciate you looking into this and getting it started. I'm a little hesitant to make a switch without much an obvious reason (to me at least) to move over to biome Right now our eslint config is ~30 lines and seems to find the most basic of issues, which is pretty much what we want. It seems like biome is going to add a lot of noise, but maybe I'm misunderstanding something. |
Biome supports all the eslint options that currently exist in the repo config, and we can just set those values the same way. It will just drop a ton of dependencies. For example enabling the |
@biomejs/biome
format:biome
andlint:biome
scriptsbiome
stepsbiomejs.biome
as a recommended extensionThis is step one in transitioning to
Biome