Properly decode element id when emulating hash scrolling (#10682)

Co-authored-by: istarkov <istarkov@gmail.com>
remix-run · Jul 7, 2023 · 4e4c08a · 4e4c08a
1 parent 26dce23
commit 4e4c08a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/decode-hash-scroll.md b/.changeset/decode-hash-scroll.md
@@ -0,0 +1,5 @@
+---
+"react-router-dom": patch
+---
+
+Properly decode element id when emulating hash scrolling via `<ScrollRestoration>`
diff --git a/contributors.yml b/contributors.yml
@@ -222,3 +222,4 @@
 - yionr
 - yuleicul
 - zheng-chuang
+- istarkov
diff --git a/packages/react-router-dom/index.tsx b/packages/react-router-dom/index.tsx
@@ -1384,7 +1384,9 @@ function useScrollRestoration({
 
       // try to scroll to the hash
       if (location.hash) {
-        let el = document.getElementById(location.hash.slice(1));
+        let el = document.getElementById(
+          decodeURIComponent(location.hash.slice(1))
+        );
         if (el) {
           el.scrollIntoView();
           return;