Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(defer): respect headers and status #10077

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

manzano78
Copy link
Contributor

Fixes the following issue:

When a Remix document request involves a loader which defer()s with specific response headers and/or status code, those are not at all respected.

Fixes issue: remix-run/remix#5345

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2023

🦋 Changeset detected

Latest commit: 5cfcc9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Minor
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@manzano78
Copy link
Contributor Author

@brophdawg11 , would it be possible to merge this as soon as possible please? In my company, we are close to ship some defer stuff in production when we noticed that the response headers were not sent to the browser (at Remix document call) when using defer

@brophdawg11 brophdawg11 self-assigned this Feb 9, 2023
@brophdawg11
Copy link
Contributor

Thanks for this PR! Would you mind adding a changeset?

We're heads down on getting Remix 1.13.0 out the door currently, but I'll see what our options are for a 1.13.1 with this after the fact or otherwise 1.14.0 should go through the normal release process next week-ish.

@manzano78 manzano78 force-pushed the fix/defer_headers_and_status branch from 1327636 to 56bb8b0 Compare February 9, 2023 17:40
@manzano78
Copy link
Contributor Author

Thanks for this PR! Would you mind adding a changeset?

We're heads down on getting Remix 1.13.0 out the door currently, but I'll see what our options are for a 1.13.1 with this after the fact or otherwise 1.14.0 should go through the normal release process next week-ish.

Oh sorry for the changeset, now it's done 👍 Thank you @brophdawg11, I love everything you do for Remix :)

@manzano78 manzano78 force-pushed the fix/defer_headers_and_status branch from 56bb8b0 to 5cfcc9a Compare February 10, 2023 13:37
@brophdawg11 brophdawg11 merged commit 93e3fec into remix-run:dev Feb 10, 2023
@brophdawg11
Copy link
Contributor

Thanks!

@manzano78 manzano78 deleted the fix/defer_headers_and_status branch February 13, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants