Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: absolute URLs on server router #10112

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Hotfix: absolute URLs on server router #10112

merged 6 commits into from
Feb 22, 2023

Conversation

thomasverleye
Copy link
Contributor

@thomasverleye thomasverleye commented Feb 18, 2023

Currently, when rendering a <Link to="mailto:foo@baz.com" /> in a server context, the href does not get rendered correctly.

See following PR in Remix for failing test: remix-run/remix#5498

I've created an additional test with <StaticRouter> in the tests of the react-router-dom tests which passes with this fix 🍾

Also fixes: #10094

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2023

🦋 Changeset detected

Latest commit: 7244657

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 18, 2023

Hi @thomasverleye,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 18, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 self-assigned this Feb 20, 2023
@thomasverleye
Copy link
Contributor Author

Any ideas when this will get merged/released, @brophdawg11?
Because we're experiencing this issue in our app we're working on and we'll be shipping the app into production pretty soon.

@timdorr timdorr requested a review from brophdawg11 February 21, 2023 19:13
@thomasverleye thomasverleye marked this pull request as draft February 22, 2023 12:23
@thomasverleye thomasverleye marked this pull request as ready for review February 22, 2023 12:23
@brophdawg11 brophdawg11 changed the base branch from main to release-next February 22, 2023 14:20
@brophdawg11
Copy link
Contributor

Thanks @thomasverleye!

@brophdawg11 brophdawg11 merged commit 8975de9 into remix-run:release-next Feb 22, 2023
@thomasverleye thomasverleye deleted the hotfix/absolute-urls-on-server branch February 22, 2023 14:42
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.2-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SSR breaks absolute URLs in Link components
3 participants