fix: treat absolute/same-origin/different-basename <Link to> values as external #10135
Conversation
🦋 Changeset detectedLatest commit: 9f5fdb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -138,7 +138,6 @@ describe("A <Link> click", () => { | |||
| <div> | |||
| <h1>Home</h1> | |||
| <Link | |||
| reloadDocument | |||
There was a problem hiding this comment.
Shouldn't have this on this Link since the external URL should be what forces it to behave as a full-document link click
|
|
||
| if (targetUrl.origin === currentUrl.origin && path != null) { | ||
| // Strip the protocol/origin/basename for same-origin absolute URLs | ||
| to = path + targetUrl.search + targetUrl.hash; |
There was a problem hiding this comment.
Must have the same basename to be considered "internal" (stripBasename returns null if it doesn't). And then we should provide the to without a basename to useHref which will prepend it back on
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Closes #10052