Do not include hash in useFormAction() for unspecified actions #10758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de78d21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
jacob-ebey
approved these changes
Aug 2, 2023
packages/react-router-dom/__tests__/data-browser-router-test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Ebey <jacob.ebey@live.com>
1 task
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include the hash in
useFormAction(undefined)since it's unavailable on the server and causes a hydration error if included. The original issue this code was added to fix was only referring to the search params not being included, we shouldn't have added the hash then. Users can still get a hash by including it in theiractionif needed and can manage hydration issues accordingly.Closes remix-run/remix#6976