Leverage useId for internal fetcher keys when available #11166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still digging but for some reason the
setState
during render ofuseFetcher
to assign the internal unique incrementingkey
causesuseId
to return unstable values on client and server. The "proper" fix for React 18 is to useuseId
to generate fetcher keys and avoid the incrementing key hack, but we need to support React 17 in React Router as well.We can feature detect
useId
and use it when available, and fall back on the current approach for React 17 and below.Closes remix-run/remix#8393