Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for document existence when checking startViewTransition #11528

Conversation

TooTallNate
Copy link
Contributor

My non-browser environment has window, but does not have document. Checking for document existence here makes React Router work for me.

Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: 15e16d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 3, 2024

Hi @TooTallNate,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 3, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 self-assigned this May 7, 2024
@brophdawg11
Copy link
Contributor

Oops - @TooTallNate sorry would you be able to rebase this and point it to dev?

@brophdawg11
Copy link
Contributor

actually, scratch that - we're about to cut a release so I cherry-picked these commits into #11544 to be included.

@brophdawg11 brophdawg11 closed this May 9, 2024
@TooTallNate TooTallNate deleted the startViewTransition-check-document branch May 9, 2024 17:27
@TooTallNate
Copy link
Contributor Author

Oh whoops, sorry about that! Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants