Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle fetcher 404s as normal boundary erorrs #9015

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

brophdawg11
Copy link
Contributor

This used to just throw via an invariant(matches), but we should handle this like any other error and bubble to the nearest boundary

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2022

🦋 Changeset detected

Latest commit: 4edb83a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 marked this pull request as ready for review June 27, 2022 14:13
@ryanflorence ryanflorence merged commit 8ed30d3 into dev Jun 27, 2022
@ryanflorence ryanflorence deleted the brophdawg11/fetcher-404s branch June 27, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants