refactor(remix-dev): replace esbuild-plugin-polyfill-node with esbuil…

…d-plugins-node-modules-polyfill (#6562)

Co-authored-by: Luke Askew <lukeaskew@gmail.com>
Co-authored-by: Ivo Todorov <ivo.gtodorov@gmail.com>

.changeset/polyfill-replacement.md

@@ -0,0 +1,6 @@
+---
+"remix": patch
+"@remix-run/dev": patch
+---
+
+replace esbuild-plugin-polyfill-node with esbuild-plugins-node-modules-polyfill

contributors.yml

@@ -318,6 +318,7 @@
 - luk-str
 - lukahartwig
 - lukasgerm
+- LukeAskew
 - lukeshiru
 - m0nica
 - m5r

packages/remix-dev/compiler/css/compiler.ts

@@ -1,6 +1,6 @@
 import { builtinModules as nodeBuiltins } from "module";
 import * as esbuild from "esbuild";
-import { polyfillNode as NodeModulesPolyfillPlugin } from "esbuild-plugin-polyfill-node";
+import { nodeModulesPolyfillPlugin } from "esbuild-plugins-node-modules-polyfill";
 
 import type { RemixConfig } from "../../config";
 import { getAppDependencies } from "../../dependencies";
@@ -81,7 +81,7 @@ const createEsbuildConfig = (ctx: Context): esbuild.BuildOptions => {
       externalPlugin(/^https?:\/\//, { sideEffects: false }),
       mdxPlugin(ctx),
       emptyModulesPlugin(ctx, /\.server(\.[jt]sx?)?$/),
-      NodeModulesPolyfillPlugin(),
+      nodeModulesPolyfillPlugin(),
       externalPlugin(/^node:.*/, { sideEffects: false }),
     ],
     supported: {

packages/remix-dev/compiler/js/compiler.ts

@@ -1,7 +1,7 @@
 import * as path from "path";
 import { builtinModules as nodeBuiltins } from "module";
 import * as esbuild from "esbuild";
-import { polyfillNode as NodeModulesPolyfillPlugin } from "esbuild-plugin-polyfill-node";
+import { nodeModulesPolyfillPlugin } from "esbuild-plugins-node-modules-polyfill";
 
 import type { RemixConfig } from "../../config";
 import { type Manifest } from "../../manifest";
@@ -133,7 +133,7 @@ const createEsbuildConfig = (
     externalPlugin(/^https?:\/\//, { sideEffects: false }),
     mdxPlugin(ctx),
     emptyModulesPlugin(ctx, /\.server(\.[jt]sx?)?$/),
-    NodeModulesPolyfillPlugin(),
+    nodeModulesPolyfillPlugin(),
     externalPlugin(/^node:.*/, { sideEffects: false }),
     {
       // TODO: should be removed when error handling for compiler is improved

packages/remix-dev/compiler/server/compiler.ts

@@ -1,5 +1,5 @@
 import * as esbuild from "esbuild";
-import { polyfillNode as NodeModulesPolyfillPlugin } from "esbuild-plugin-polyfill-node";
+import { nodeModulesPolyfillPlugin } from "esbuild-plugins-node-modules-polyfill";
 
 import { type Manifest } from "../../manifest";
 import { loaders } from "../utils/loaders";
@@ -67,7 +67,7 @@ const createEsbuildConfig = (
   ];
 
   if (ctx.config.serverPlatform !== "node") {
-    plugins.unshift(NodeModulesPolyfillPlugin());
+    plugins.unshift(nodeModulesPolyfillPlugin());
   }
 
   return {

packages/remix-dev/package.json

@@ -36,7 +36,7 @@
     "chokidar": "^3.5.1",
     "dotenv": "^16.0.0",
     "esbuild": "0.17.6",
-    "esbuild-plugin-polyfill-node": "^0.2.0",
+    "esbuild-plugins-node-modules-polyfill": "^1.0.13",
     "execa": "5.1.1",
     "exit-hook": "2.2.1",
     "express": "^4.17.1",