Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorators error after upgrading to 1.16.0 #6353

Closed
markdalgleish opened this issue May 8, 2023 Discussed in #6326 · 9 comments
Closed

Decorators error after upgrading to 1.16.0 #6353

markdalgleish opened this issue May 8, 2023 Discussed in #6326 · 9 comments
Assignees
Labels
bug Something isn't working package:dev

Comments

@markdalgleish
Copy link
Member

Discussed in #6326

Originally posted by erandow May 6, 2023
After upgrading remix to the latest version(1.16.0),
I get the following error after running project locally.]
The 'decorators' plugin requires a 'decoratorsBeforeExport' option, whose value must be a boolean. If you are migrating from Babylon/Babel 6 or want to use the old decorators proposal, you should use the 'decorators-legacy' plugin instead of 'decorators'. [plugin css-side-effects-plugin]
I also set the future.unstable_cssSideEffectImports: true but the errors still exist.

@markdalgleish markdalgleish added bug Something isn't working package:dev labels May 8, 2023
@markdalgleish markdalgleish self-assigned this May 8, 2023
@markdalgleish
Copy link
Member Author

@erandow I haven't been able to reproduce the issue. Could you please share a repro?

@markdalgleish
Copy link
Member Author

@erandow It looks like the decoratorsBeforeExport option is deprecated: https://babel.dev/docs/babel-parser#plugins-options. This seems likely to do with an older version of @babel/parser. Are you able to confirm which version you're using?

@nakleiderer
Copy link

I had a similar issue when I upgraded only Remix, but it went away when I upgraded all outdated packages in my app. I imagine npm was picking up an older version of babel for one of my other dependencies.

@markdalgleish
Copy link
Member Author

This shouldn't be an ongoing issue once #6390 goes out.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-9de3c4b-20230515 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@markdalgleish
Copy link
Member Author

@erandow Are you able to check your issue against the night release?

@erandow
Copy link

erandow commented May 16, 2023

@markdalgleish,
Thanks for creating an issue and trying to fix the issue.
Sorry, I was offline and couldn't answer your questions.

Thanks, It seems that there is no problem with the nightly release.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:dev
Projects
None yet
Development

No branches or pull requests

3 participants