Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize future flags #10072

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Stabilize future flags #10072

merged 6 commits into from
Oct 9, 2024

Conversation

brophdawg11
Copy link
Contributor

Stacked on #9980

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d4bbd2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Minor
@remix-run/react Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/node Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/serve Minor
create-remix Minor
remix Minor
@remix-run/css-bundle Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

brophdawg11
brophdawg11 commented Oct 7, 2024
View reviewed changes
packages/remix-dev/config.ts
Comment on lines -532 to -536
if (isSpaMode && appConfig.future?.unstable_lazyRouteDiscovery === true) {
throw new Error(
"You can not use `future.unstable_lazyRouteDiscovery` in SPA Mode (`ssr: false`)"
);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was unintentionally left in here from a first pass - we decided up front that SPA mode would just not have fog of war so its never enabled at run time, so no need to fail the build (which would be a problem in RR v7 anyway)

export function isFogOfWarEnabled(future: FutureConfig, isSpaMode: boolean) {
  return future.v3_lazyRouteDiscovery === true && !isSpaMode;
}

Base automatically changed from brophdawg11/stabilize-apis to dev October 9, 2024 17:11
@brophdawg11 brophdawg11 merged commit 9f9cb66 into dev Oct 9, 2024
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/stabilize-flags branch October 9, 2024 17:48
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Oct 9, 2024
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🤖 Hello there,

We just published version 2.13.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Oct 11, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.13.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed package:dev package:server-runtime renderer:react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brophdawg11