-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace node-fetch with @remix-run/web-fetch #2736
Conversation
bind formData to request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start. Keep going! Let's also look into getting rid of busboy and using our own multipart parser in web-std/form-data.
feat: updated upload handlers to use new API fix: clean up adapters
feat: remove abort controller from adapters and request
Co-authored-by: Michael Jackson <michael@jackson.us>
added more formdata tests
chore: updated cloudinary upload example
…nd export it for use
removed jsdocs
docs: updated docs to include note about not reading body in loader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Breaking unstable_ API should be fine.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Any obvious reason I'd be getting this after upgrading from 1.4? If not, I'll try to submit a repro or fix.
|
This PR replaces the internal usage of
node-fetch
with@remix-run/web-fetch
to be more spec compliant and allow for ReadableStream's to be used as a body in node.This work is critical to enable a runtime agnostic way to implement streaming in the server-runtime package and provide React 18 support to everyone.
I have also re-worked the file upload handler API to operate on an AsyncIterable for the body content. This allows for better error propagation as well as bringing
unstable_parseMultipartFormData
to all supported platforms, not just Node.